New is_pickled_module() function
#556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogama
changed the title
is_pickled_module() function
mmckerns
requested changes
Feb 1, 2023
| return False | ||
| is_runtime_mod = pickle_main.startswith('__runtime__.') | ||
| res = importable ^ is_runtime_mod | ||
| if res and identify: |
There was a problem hiding this comment.
I think this function could be named pickled_module or identify_module, and the identify kwarg set to always be true and then removed.
|
|
||
| Parameters: | ||
| filename: a path-like object or a readable stream. | ||
| importable: expected kind of the file's saved module. Use `True` for |
There was a problem hiding this comment.
This doc is slightly confusing, especially if people might think that the file itself is importable (without first unpickling). Fundamentally, it's either a file-like module object or a module class instance... so is something in that vein a better name? It's a bit of an unusual thing for people to think about, so lets give the name some extra thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #475 / #527
Also fixes
_identify_module()-> raises exception for modules saved withdump()